Skip to content

feat: Add option for admins to delete empty namespaces#1773

Merged
netomi merged 8 commits intoeclipse-openvsx:mainfrom
autumnfound:malowe/main/1519
Apr 22, 2026
Merged

feat: Add option for admins to delete empty namespaces#1773
netomi merged 8 commits intoeclipse-openvsx:mainfrom
autumnfound:malowe/main/1519

Conversation

@autumnfound
Copy link
Copy Markdown
Contributor

Creates a new admin-only endpoint that enables deletion through the Namespace section of the admin dashboard. This will appear as a new button in the namespace search result with a modal to prevent accidental deletion.

Additionally, fixes an out of date instruction in the README and deployment docs that can block testing.

Included, screenshots of the UI update to include the new delete button.

image image

Creates a new admin-only endpoint that enables deletion through the Namespace section of the admin dashboard. This will appear as a new button in the namespace search result with a modal to prevent accidental deletion.
@autumnfound autumnfound requested review from gnugomez and netomi April 17, 2026 18:30
@autumnfound
Copy link
Copy Markdown
Contributor Author

There's a weird issue w/ one of the tests, the test at line https://github.com/eclipse-openvsx/openvsx/pull/1773/changes#diff-f13da4c0f8d9066d35be9c1884b95ed10d1aa1a4fa4f1e1e47215bda7ba4b102R628 has the mockAdminUser(); like the other tests, but fails saying it isn't an admin user. Not really sure what's going on there, but I'll look a little more to see if I can figure it out. I tested this locally and it worked fine.

autumnfound and others added 5 commits April 20, 2026 09:21
Previous iteration added an optional number of members to stub in for memberships. This used the mock user test method, which replaced the admin user in the findLoggedInUser check. This broke the test that used the additional members, and needed to be accommodated.
netomi
netomi previously approved these changes Apr 22, 2026
Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
Copy link
Copy Markdown
Contributor

@netomi netomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netomi netomi merged commit 5399f33 into eclipse-openvsx:main Apr 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants